After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 553911 - [PATCH] Fix build with gdl enabled
[PATCH] Fix build with gdl enabled
Status: RESOLVED FIXED
Product: gnome-python-extras
Classification: Deprecated
Component: gdl
CVS HEAD
Other Linux
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2008-09-26 10:04 UTC by Johannes Schmid
Modified: 2008-11-17 12:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix build with gdl enabled (701 bytes, patch)
2008-09-26 10:06 UTC, Johannes Schmid 		none Details | Review
Modified version of first patch (2.53 KB, patch)
2008-10-06 04:44 UTC, Andi Albrecht 		committed Details | Review

Description Johannes Schmid 2008-09-26 10:04:42 UTC 
This (trivial) changes fixes the build when gdl is enabled.
Comment 1 Johannes Schmid 2008-09-26 10:06:20 UTC 
Created attachment 119407 [details] [review]
Fix build with gdl enabled
Comment 2 Andi Albrecht 2008-10-06 04:43:42 UTC 
In addition to Johannes' patch I'll had to remove all gdl_icon* stuff from gdl.defs and remove gdl-gnome-1.0 dependency to make it build on my machine (Debian/unstable, libgdl 2.24.0). The version of gdl bindings currently distributed in unstable is build with HAVE_0_7=false because of the obsolote gdl-gnome requirement. In turn it has no gdl.ComboButton.

FWIW I attach a modified version of the first patch that gives me at least the ComboButton back ;-)
Comment 3 Andi Albrecht 2008-10-06 04:44:53 UTC 
Created attachment 119997 [details] [review]
Modified version of first patch
Comment 4 Alex Lancaster 2008-10-27 08:07:56 UTC 
Will this only apply against SVN?  I'm trying to fix the package on Fedora (rawhide, soon-to-be F-10) which fails to build with new libgdl because libgdl dropped libgnome-gdl and it won't apply against 2.19.1.
Comment 5 Johannes Schmid 2008-10-27 18:07:47 UTC 
i do not know if it applies to 2.19 but when you look at the patch it should be pretty obvious what you have to change
Comment 6 Murray Cumming 2008-10-27 18:13:27 UTC 
Gustavo, is this OK to commit?
Comment 7 Gustavo Carneiro 2008-10-28 15:17:33 UTC 
What a mess that is GDL.  First they had no gdl-gnome, then they add gdl-gnome pc file, and now they drop it again? :|
Comment 8 Johannes Schmid 2008-10-29 17:15:14 UTC 
Sorry about that but we had to separate gdl-gnome out to be able to build a version without gnome depencies. No that we converted everything to gio/gtk+ (or things became obsolete because gtk+ provides them now), we needed to drop it.