After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 529047 - epiphany-webkit don't store cookies
epiphany-webkit don't store cookies
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Backend
git master
Other All
: Normal normal
: ---
Assigned To: Xan Lopez
Epiphany Maintainers
: 541325 553074 (view as bug list)
Depends on:
Blocks: 538441
 
 
Reported: 2008-04-20 13:53 UTC by Luca Ferretti
Modified: 2009-02-23 11:50 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24

Attachments
Ephy cookies with libsoup (20.43 KB, patch)
2008-10-28 20:56 UTC, Xan Lopez 		none Details | Review
ephycookies.patch (32.84 KB, patch)
2009-02-20 08:26 UTC, Xan Lopez 		none Details | Review
ephycookies.patch (33.32 KB, patch)
2009-02-20 12:09 UTC, Xan Lopez 		none Details | Review
ephycookies.patch (33.29 KB, patch)
2009-02-20 12:35 UTC, Xan Lopez 		committed Details | Review

Description Luca Ferretti 2008-04-20 13:53:50 UTC 
As per summary, epiphany-webkit is able to work with sites requiring cookies (while I'm not sure this is true for libsoup backend too), but cookies are not available in Edit->Personal Data dialog.

PS To test if browser is able to accept session cookies, see http://www.pageout.net/page.dyn/cookie_tester or http://www.html-kit.com/tools/cookietester/
Comment 1 Matt Joras 2008-05-10 18:16:03 UTC 
Same thing here, although those tests claim I have cookies working, none ever get stored, like cookies for "remember me" for passwords/usernames.
Comment 2 Reinout van Schouwen 2008-07-03 11:29:58 UTC 
*** Bug 541325 has been marked as a duplicate of this bug. ***
Comment 3 Reinout van Schouwen 2008-09-21 13:32:43 UTC 
*** Bug 553074 has been marked as a duplicate of this bug. ***
Comment 4 Alexander V. Butenko 2008-09-22 07:10:13 UTC 
no news regarding this issue?
Comment 5 Xan Lopez 2008-10-28 20:18:24 UTC 
We are working to add the needed functionality to libsoup (http://bugzilla.gnome.org/show_bug.cgi?id=522125). It's pretty close to being done. Once that's done I'll put here a fairly simple patch for epiphany and it should be good to go.
Comment 6 Xan Lopez 2008-10-28 20:56:45 UTC 
Created attachment 121538 [details] [review]
Ephy cookies with libsoup

Just attaching the patch in case I'm hit by a bus or something (or, hopefully more likely, in case someone wants to have a look).
Comment 7 Alexander V. Butenko 2008-11-24 03:55:10 UTC 
webkit itself already has cookies management. it also can store them in a file. 

WebCore/platform/network/curl/ResourceHandleManager.cpp
ResourceHandleManager::setCookieJarFileName(char *filename)

it stores cookies in mozilla-like cookies.txt file
Comment 8 Cosimo Cecchi 2008-12-03 13:34:54 UTC 
For the record, this depends on https://bugs.webkit.org/show_bug.cgi?id=22624.
Comment 9 Xan Lopez 2009-02-20 08:26:30 UTC 
Created attachment 129130 [details] [review]
ephycookies.patch

Use the latest (and hopefully final) WebKit API, and SoupCookieJarSQLite for storage. Needs libsoup trunk.
Comment 10 Xan Lopez 2009-02-20 12:09:50 UTC 
Created attachment 129139 [details] [review]
ephycookies.patch

Fix crasher, reported by Christopher Williams (crldb).
Comment 11 Xan Lopez 2009-02-20 12:35:10 UTC 
Created attachment 129143 [details] [review]
ephycookies.patch

Undo stupid mistake in last patch...
Comment 12 Xan Lopez 2009-02-23 11:50:39 UTC 
Committed in trunk, r8811. Needs WebKit trunk, at least r41139.