After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 518338 - epiphany-webkit: cannot open links in new tabs
epiphany-webkit: cannot open links in new tabs
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Backend
git master
Other All
: Normal major
: ---
Assigned To: Xan Lopez
Epiphany Maintainers
: 519006 555657 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-02-24 01:00 UTC by Michael Gilbert
Modified: 2008-12-21 16:08 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26


Attachments
Enables opening of links in new tabs by pressing the middle mouse button (13.70 KB, patch)
2008-12-06 19:56 UTC, Michael Opitz
none Details | Review
Enables opening of links in new tabs by pressing the middle mouse button and the context menu (17.57 KB, patch)
2008-12-08 15:11 UTC, Michael Opitz
none Details | Review
0001-Open-links-in-new-tab-with-middle-click.patch (2.45 KB, patch)
2008-12-21 10:39 UTC, Xan Lopez
committed Details | Review

Description Michael Gilbert 2008-02-24 01:00:41 UTC
Please describe the problem:
here's another bug with the latest version of epiphany-webkit.

it is currently not possible to open a link in a new tab (or a new
window for that matter). the "Open Link in New Window" option in the
right-click menu does not work.  also, there is no "Open Link in New Tab"
option in the that menu.  and finally, middle-click on a link
does not open the link in a new tab.

thanks for the hard work.

this is debian bug #467237 (http://bugs.debian.org/467237).

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Xan Lopez 2008-03-01 11:47:20 UTC

*** This bug has been marked as a duplicate of 519006 ***
Comment 2 Xan Lopez 2008-03-01 11:48:42 UTC
*** Bug 519006 has been marked as a duplicate of this bug. ***
Comment 3 Michael Monreal 2008-04-01 23:01:44 UTC
I just had a user ask for this in a forum. Would be really nice to have this feature back soon!
Comment 4 Martin Sourada 2008-05-31 09:51:07 UTC
I noticed in the

http://live.gnome.org/Epiphany/WebKit/TODO

page that this bug depends on some WebKit bug, but in midori (also uses webkit-gtk backend; http://software.twotoasts.de/?page=midori) the middle-click to open in new tab works flawlessly...
Comment 5 Iñigo Illan 2008-07-17 13:50:19 UTC
Yep, I've just been watching around, and midori uses hovering-over-link signal. It's used when mouse enters or exits from a link-space.  
Comment 6 Reinout van Schouwen 2008-10-09 14:01:20 UTC
*** Bug 555657 has been marked as a duplicate of this bug. ***
Comment 7 Luca Ferretti 2008-11-28 12:46:03 UTC
I think we can confirm this bug :)
Updated other info too.
Comment 8 Michael Opitz 2008-12-06 19:56:20 UTC
Created attachment 124067 [details] [review]
Enables opening of links in new tabs by pressing the middle mouse button

Hello,

I've created an initial patch, which enables opening of links in new tabs by pressing the middle mouse button or CTRL + left mouse button. It uses the hovering-over-link technique of midori. The "Open Link in New Tab" is, however, still missing though :(. It seems that midori is using the populate-popup signal, which allows the receiver of the signal to modify the popup-menu on the fly before it will be displayed.
Comment 9 Michael Opitz 2008-12-08 15:11:43 UTC
Created attachment 124176 [details] [review]
Enables opening of links in new tabs by pressing the middle mouse button and the context menu

Hi,

I've added the "Open Link in New Tab"-Button to the patch using the same method as midori (by connecting to the populate-popup signal)
Comment 10 Xan Lopez 2008-12-08 15:15:08 UTC
Hrm, we are actually on pretty good track to have the relevant WebKit bugs landed in the near future, so I wonder if it makes much sense to have these workarounds in trunk at this point.
Comment 11 Xan Lopez 2008-12-21 10:39:38 UTC
Created attachment 125087 [details] [review]
0001-Open-links-in-new-tab-with-middle-click.patch

When https://bugs.webkit.org/show_bug.cgi?id=16092 is committed this patch can go in to fix 'open links in new tab with middle click'.

I'll be offline from the 22nd to the 2nd of January or so, so anybody feel free to commit this if the webkit patch does not make it in time.
Comment 12 Xan Lopez 2008-12-21 16:03:13 UTC
This is in trunk now, closing.