After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 310205 - pathbar inconsistent when clicking a folder that no longer exists
pathbar inconsistent when clicking a folder that no longer exists
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Navigation
2.30.x
Other All
: Normal normal
: 3.0
Assigned To: Nautilus Maintainers
Nautilus Maintainers
nautilus[EMC08]
: 310920 317851 320129 327691 333325 334348 352985 481442 529250 549086 549109 587393 619759 620964 627007 629030 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-07-13 10:16 UTC by Michaël Arnauts
Modified: 2010-09-08 10:44 UTC
See Also:
GNOME target: ---
GNOME version: 2.29/2.30


Attachments
screenshots say more then 1000 words (22.28 KB, image/png)
2005-07-13 10:17 UTC, Michaël Arnauts
  Details
Patch to remove non-existant path buttons (3.13 KB, patch)
2009-06-29 00:55 UTC, Ted M Lin
rejected Details | Review
Patch to remove non-existant path buttons (revised) (2.24 KB, patch)
2009-09-02 23:17 UTC, Ted M Lin
reviewed Details | Review
update history when folder is renamed (1.44 KB, patch)
2009-09-02 23:20 UTC, Ted M Lin
rejected Details | Review

Description Michaël Arnauts 2005-07-13 10:16:29 UTC
- Open a browser window
- Create a folder
- Open the folder
- Go back to the parent folder
- Remove the newly created folder
- Click the old folder that is still in the pathbar

A message is shown:

 Can't display location
 Please check the spelling and try again.

The removed folder-button is still in the down state.

I guess perhaps the pathbar can communicate with FAM or so and remove the button
if the folder is removed also...
Comment 1 Michaël Arnauts 2005-07-13 10:17:02 UTC
Created attachment 49081 [details]
screenshots say more then 1000 words
Comment 2 Christian Neumair 2005-07-13 10:18:53 UTC
Thanks for your bug report!
Comment 3 Vincent Noel 2005-08-10 22:28:11 UTC
*** Bug 310920 has been marked as a duplicate of this bug. ***
Comment 4 Sebastien Bacher 2005-11-13 15:30:37 UTC
*** Bug 320129 has been marked as a duplicate of this bug. ***
Comment 5 Christian Neumair 2005-11-13 15:53:10 UTC
I've askes Alex about the problems and here is what he thinks:

Is this really a huge problem though? If you click on on the deleted
folder, don't you get told that its not there anymore? 
The problem with monitors are: 
a) They can keep a mount from going unmounted. This is fine if you're
actively displaying the mount, but is very weird if something passive
like the "history" in the pathbar actively blocks an unmount
b) They are not especially cheap. Especially the way we now handle
monitoring in Nautilus, always watching the whole directory.
Comment 6 Alexander “weej” Jones 2005-11-13 16:41:36 UTC
"Couldn't find "/home/alex/untitled folder".

Please check the spelling and try again."

a) This is a BAD error message. Spelling has nothing to do with it. Whatever
needs to be done to change this needs to be done.
b) Clicking OK leaves the button in a pressed state. This just seems wrong. The
button should not be insensitive, because the folder might re-appear, but I
suggest an X icon on the button to indicate that it was inaccessible or something.

Also if you are already monitoring the current folder for changes, we might as
well detect folder deletions (if not the entire tree).

And monitoring blocking unmounts? That just seems fundamentally wrong. If you
are monitoring a folder and then it is unmounted, that should surely trigger
something, much the same way as deleting the folder would.
Comment 7 Paolo Borelli 2005-11-13 16:55:13 UTC
I may be totally wrong since I didn't look at the code, but does this really
need to be done using monitors? I guess that removing the deleted subdirs from
the pathbar after activating the delete command from nautilus would catch 99% of
the cases. If someone rm -rf from the shell he'll continue to get the current
error dialogs.
Comment 8 Christian Neumair 2005-11-13 17:54:29 UTC
I agree with you Paolo.
Comment 9 Sebastien Bacher 2005-11-18 11:14:27 UTC
*** Bug 317851 has been marked as a duplicate of this bug. ***
Comment 10 Teppo Turtiainen 2006-03-19 09:28:25 UTC
*** Bug 333325 has been marked as a duplicate of this bug. ***
Comment 11 Teppo Turtiainen 2006-03-19 09:28:39 UTC
*** Bug 334348 has been marked as a duplicate of this bug. ***
Comment 12 Teppo Turtiainen 2007-01-09 15:20:02 UTC
*** Bug 352985 has been marked as a duplicate of this bug. ***
Comment 13 Teppo Turtiainen 2007-03-10 19:20:22 UTC
Still occurs with Nautilus 2.17.92 on Ubuntu Feisty.
Comment 14 Teppo Turtiainen 2007-03-10 19:47:11 UTC
(In reply to comment #7)
> I guess that removing the deleted subdirs from the pathbar after activating
> the delete command from nautilus would catch 99% of the cases.

Bug 327691 has a patch that does this.
Comment 15 Mark Campbell 2007-03-23 04:09:08 UTC
I would expect that when a folder is renamed, nautilus would perform the operation and update the location bar and the folder contents of all affected open windows to reflect the change.  The same goes for removing a folder.  If I'm not mistaken, the folder contents of all affected open windows are updated this way.  Why not the location bar as well?  If a folder is removed, the buttons in the location bar for that folder and any subfolders should be removed.
Comment 16 Cosimo Cecchi 2008-01-18 19:29:21 UTC
*** Bug 481442 has been marked as a duplicate of this bug. ***
Comment 17 André Klapper 2008-01-26 11:58:55 UTC
does this still happen with 2.21.x?
Comment 18 Baptiste Mille-Mathias 2008-01-26 12:43:17 UTC
Hello Andre,

Yep it's still accurate
Comment 19 André Klapper 2008-01-26 15:18:32 UTC
then crevette may want to update the version info :)
Comment 20 Cosimo Cecchi 2008-04-21 17:51:50 UTC
*** Bug 529250 has been marked as a duplicate of this bug. ***
Comment 21 Wouter Bolsterlee (uws) 2008-10-15 10:53:08 UTC
Bug 549086 has a screenshot as well...
Comment 22 Wouter Bolsterlee (uws) 2008-10-15 10:53:10 UTC
*** Bug 549086 has been marked as a duplicate of this bug. ***
Comment 23 Cosimo Cecchi 2009-03-21 18:18:45 UTC
*** Bug 549109 has been marked as a duplicate of this bug. ***
Comment 24 Cosimo Cecchi 2009-03-21 18:21:29 UTC
*** Bug 327691 has been marked as a duplicate of this bug. ***
Comment 25 Cosimo Cecchi 2009-03-21 18:22:22 UTC
Duplicate bug 327691 has an unfinished (and probably obsolete) patch that could be used as a starting point for this (attachment 78415 [details] [review]).
Comment 26 Ted M Lin 2009-06-29 00:55:08 UTC
Created attachment 137519 [details] [review]
Patch to remove non-existant path buttons

Patch against nautilus 2.26.2. (May not completely unref memory...)
This removes the button corresponding to a deleted directory (and the ones underneath).  This also fixes handling of buttons on folder renaming.
Comment 27 Cosimo Cecchi 2009-07-09 17:34:51 UTC
*** Bug 587393 has been marked as a duplicate of this bug. ***
Comment 28 Cosimo Cecchi 2009-07-09 17:56:42 UTC
The patch seems to be mixed with some other different stuff which doesn't belong to this bug fix.
Anyway, I am cooking up an updated patch for this that takes care of also removing the trashed items from the Nautilus history as well.
Comment 29 Scott Kostyshak 2009-07-25 23:29:53 UTC
2.27.5 still has this problem.
Comment 30 Ted M Lin 2009-09-02 23:17:58 UTC
Created attachment 142368 [details] [review]
Patch to remove non-existant path buttons (revised)

Here's an updated patch (against HEAD) with the extraneous code removed (sorry!).

I also started looking at fixing the history list, but am making slow progress...
Comment 31 Ted M Lin 2009-09-02 23:20:32 UTC
Created attachment 142369 [details] [review]
update history when folder is renamed

I did find the history code that handles renaming folders. This patch seems to work, but I'm still working my way through the many uses of NautilusBookmark.
Comment 32 Cosimo Cecchi 2010-05-27 23:56:58 UTC
*** Bug 619759 has been marked as a duplicate of this bug. ***
Comment 33 Cosimo Cecchi 2010-05-27 23:57:38 UTC
We should definitely take care of this for 3.0.
Comment 34 Vish 2010-07-01 11:31:50 UTC
(In reply to comment #33)
> We should definitely take care of this for 3.0.

Is the patch in comment#31 good?
Maybe we can milestone it so that we dont miss it?
Comment 35 Cosimo Cecchi 2010-07-01 12:53:32 UTC
Comment on attachment 142369 [details] [review]
update history when folder is renamed

This was just a workaround. I fixed the root cause in master, see http://git.gnome.org/browse/nautilus/commit/?id=d1446086855ec1a673b144befff5b707244b998c
Comment 36 Cosimo Cecchi 2010-07-01 15:16:35 UTC
I committed that patch minus some bit of changes to master, so that we can at least fix this bug for the pathbar.
Comment 37 Marcus Carlson 2010-07-29 22:48:05 UTC
*** Bug 620964 has been marked as a duplicate of this bug. ***
Comment 38 Cosimo Cecchi 2010-08-20 10:27:01 UTC
*** Bug 627007 has been marked as a duplicate of this bug. ***
Comment 39 Cosimo Cecchi 2010-09-08 10:44:57 UTC
*** Bug 629030 has been marked as a duplicate of this bug. ***